Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to control state from refs during onDrag #577

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bluematter
Copy link

Problem

When dragging it's a challenge to manage state from refs because internally this.setState will always override any refs.setState making it useless.

Even if you return false from the function DraggableCore will this.handleDragStop(new MouseEvent('mouseup')); trigger drag stop.

Solution

Return an object with a key controlled and if it's true it will short circuit onDrag giving the custom callback the ability to control the state.

https://www.loom.com/share/2ca4ef824bc2404bac0cbf2f8108de2c

bluematter and others added 3 commits June 5, 2021 12:13
This is useful when you need to manage setState from refs
When controlling state from refs return before state gets set inside handleDrag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants